Stop rendering album cards that are off screen, and split card blur from panel blur
Searching a single letter over a real library puts 340 cards in one grid, each with a cover image, a shadow and a backdrop blur, all of them live whether or not they are on screen. On musicdolphin that saturated the renderer badly enough that a DevTools Runtime.evaluate could not be scheduled on the main thread inside 30 seconds, which is a fair description of what "sluggish" felt like. content-visibility: auto on the grid's cards is the browser's own answer: off-screen cards skip layout, paint and compositing and come back as they scroll near the viewport. The grid's tracks are sized by minmax(180px, 1fr) rather than by card content, so skipping that content cannot move the columns; contain-intrinsic-size supplies the block-axis guess and `auto` remembers each card's real size after its first render, so scroll height and offsetTop - which BrowseView's keep-the-selection- on-screen effect reads - stay honest. Not behind ?pi=1: there is no visual difference to trade away. SHOW_CARD_BLUR separates the repeated frosted surfaces (every card, every list row) from the handful of panels wrapped around them, because the two behave nothing alike and lumping them together is what made the first Pi profile five times slower. A panel is one live backdrop copy that buys its whole subtree a compositing layer; a card is one of three hundred sitting directly over the animated canvas. ?pi=1 now drops the card blur and keeps the panel blur. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -157,6 +157,17 @@ button {
|
||||
box-shadow: 0 4px 14px var(--shadow);
|
||||
}
|
||||
|
||||
/* `SHOW_CARD_BLUR` (`lib/theme.ts`) off sets `data-cardblur="off"` - drop the backdrop
|
||||
blur from the surfaces there are *many* of, and only those. An album grid is up to
|
||||
343 cards, each one a live backdrop copy sitting directly over the animated canvas,
|
||||
so every canvas frame re-blurs all of them. The panels below keep their blur: a
|
||||
panel is one copy, and it is what gives its whole subtree a compositing layer. */
|
||||
.stage[data-cardblur="off"] .card,
|
||||
.stage[data-cardblur="off"] .list-row {
|
||||
backdrop-filter: none;
|
||||
-webkit-backdrop-filter: none;
|
||||
}
|
||||
|
||||
/* `SHOW_GLASS_BLUR` (`lib/theme.ts`) off sets `data-blur="off"` on `.stage` - drop
|
||||
the (GPU-expensive) backdrop blur everywhere below and fall back to each
|
||||
element's own plain translucent background. */
|
||||
@@ -199,6 +210,27 @@ button {
|
||||
margin: 0 auto;
|
||||
}
|
||||
|
||||
/* Searching "e" over a real library puts 340 cards in this grid at once, each one a
|
||||
cover image, a shadow and a backdrop blur, all of them live whether or not they are
|
||||
on screen. On the Pi that saturated the renderer so completely that a DevTools
|
||||
evaluate could not be scheduled on the main thread inside 30 seconds - which is
|
||||
exactly what "sluggish" felt like.
|
||||
|
||||
`content-visibility: auto` is the browser's own answer to this and costs nothing
|
||||
elsewhere: off-screen cards skip layout, paint and compositing entirely, and come
|
||||
back the moment they scroll near the viewport. The grid's tracks are sized by
|
||||
`minmax(180px, 1fr)` rather than by card content, so skipping that content cannot
|
||||
change the column layout; `contain-intrinsic-size` supplies the block-axis guess
|
||||
(a card measured 185x289 on the device) and `auto` then remembers each card's real
|
||||
size once it has been rendered once, so scroll height and `offsetTop` - which the
|
||||
keep-the-selection-on-screen effect in BrowseView reads - stay honest.
|
||||
|
||||
Deliberately not behind ?pi=1: there is no visual difference to trade away. */
|
||||
.grid > .card {
|
||||
content-visibility: auto;
|
||||
contain-intrinsic-size: auto 289px;
|
||||
}
|
||||
|
||||
.shelf-row {
|
||||
display: flex;
|
||||
gap: 12px;
|
||||
|
||||
Reference in New Issue
Block a user